Add option to disable SNI for TLS connections#344
Merged
Conversation
Collaborator
Author
|
In case you can take a quick look, @nniclausse, that would be great. Apart from this, I've tested this successfully and also updated the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing a HTTP-based system using mutual TLS authentication (= client and server TLS certificates) I ran into several issues with Erlang and errors during TLS handshakes when using TLS client certificates. The root cause is not fully understood currently, but the parts of the solution is :)
Server Name Indication (SNI) is a TLS extension allowing the server to receive a hostname indication the client wishes to connect to.
According to http://erlang.org/doc/man/ssl.html#tls-dtls-option-descriptions---client-side,
{server_name_indication, disable}can be used to disable SNI:This PR introduces the following option: