Support RFC 7395 (WebSocket) framing#397
Merged
prefiks merged 1 commit intoprocessone:developfrom Jul 27, 2022
Merged
Conversation
If '<jabber type="connect" version="websocket" [...]/>' is specified, use RFC 7395 framing for opening and closing the stream. Resolves processone#164.
|
I have tested this change with good results: it now becomes possible to have XMPP interaction over websockets. There are optimisations possible, but the change as-is removes an impossibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support WebSocket framing as per RFC 7385 for opening and closing the stream.
This behavior is only enabled if
<jabber type="connect" version="websocket" [...]/>is specified. Enabling it by default for WebSocket connections would require more changes to the code, which currently has a strict separation of the transport vs. application layers, with no access to the state of the other layer.Resolves #164.