New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve admin a11y #1

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@marcus-herrmann
Contributor

marcus-herrmann commented Sep 3, 2016

Hi Ryan,

I don't know how you will handle Merge Requests in this repo/from now on, but I thought I'll just give it a shot.

This PR improves keyboard acessibility in ProcessWire admin:

In order to use both features, the corresponding scripts have to be built/minified of course.

Kind regards,
Marcus

@ryancramerdesign

Thanks Marcus, looks good. The only thing is I don't think we need the ESC key code in main.js, since this can already be accommodated by the closeOnEscape jQuery dialog option.

@marcus-herrmann

This comment has been minimized.

Show comment
Hide comment
@marcus-herrmann

marcus-herrmann Oct 5, 2016

Contributor

Alright. The ESC idea originates from the topic linked above and I thought "well, let's do a combined a11y"-PR ;)

Will you cherry pick Commit cfe5d89, or should I create a new Merge Request with just that commit or will you transfer it manually?

Since we're communicating and talking about accessibility: ryancramerdesign/ProcessWire#1758 - here's my PR from the old repo with some subtle changes to inbuilt site profiles. Should I recreate the same PR for this very repo or is it also a manual transfer thing?

Either way: thanks for your great work!

Contributor

marcus-herrmann commented Oct 5, 2016

Alright. The ESC idea originates from the topic linked above and I thought "well, let's do a combined a11y"-PR ;)

Will you cherry pick Commit cfe5d89, or should I create a new Merge Request with just that commit or will you transfer it manually?

Since we're communicating and talking about accessibility: ryancramerdesign/ProcessWire#1758 - here's my PR from the old repo with some subtle changes to inbuilt site profiles. Should I recreate the same PR for this very repo or is it also a manual transfer thing?

Either way: thanks for your great work!

@ryancramerdesign

This comment has been minimized.

Show comment
Hide comment
@ryancramerdesign

ryancramerdesign Oct 5, 2016

Contributor

No need to submit another, I can cherry pick no problem. We are using a CLA with this new repo, would you mind completing the second bullet point from the PR section of the CONTRIBUTING.md file? https://github.com/processwire/processwire/blob/master/CONTRIBUTING.md#pull-requests-prs

For the other PR, if it's easy to create a new PR for it here, then great. If not, then no worries I can make the adjustments without a PR.

Contributor

ryancramerdesign commented Oct 5, 2016

No need to submit another, I can cherry pick no problem. We are using a CLA with this new repo, would you mind completing the second bullet point from the PR section of the CONTRIBUTING.md file? https://github.com/processwire/processwire/blob/master/CONTRIBUTING.md#pull-requests-prs

For the other PR, if it's easy to create a new PR for it here, then great. If not, then no worries I can make the adjustments without a PR.

@marcus-herrmann

This comment has been minimized.

Show comment
Hide comment
@marcus-herrmann

marcus-herrmann Oct 5, 2016

Contributor

CLA is signed.

Since I managed to sprain my wrist yesterday (oh the irony, regarding this PR's topic) I'd like to take your offer of making the adjustments manually :)

Contributor

marcus-herrmann commented Oct 5, 2016

CLA is signed.

Since I managed to sprain my wrist yesterday (oh the irony, regarding this PR's topic) I'd like to take your offer of making the adjustments manually :)

@ryancramerdesign

This comment has been minimized.

Show comment
Hide comment
@ryancramerdesign

ryancramerdesign Oct 5, 2016

Contributor

Thanks, sounds good. :) Hope your wrist is alright.

Contributor

ryancramerdesign commented Oct 5, 2016

Thanks, sounds good. :) Hope your wrist is alright.

ryancramerdesign added a commit that referenced this pull request Oct 5, 2016

Add @marcus-herrmann PR #1 which improves keyboard accessibility of P…
…rocessPageList, enabling use of spacebar to toggle actions open/closed.

foobarlab pushed a commit to foobarlab/processwire that referenced this pull request Sep 15, 2017

Add @marcus-herrmann PR #1 which improves keyboard accessibility of P…
…rocessPageList, enabling use of spacebar to toggle actions open/closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment