Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature/improve admin a11y #1
I don't know how you will handle Merge Requests in this repo/from now on, but I thought I'll just give it a shot.
This PR improves keyboard acessibility in ProcessWire admin:
In order to use both features, the corresponding scripts have to be built/minified of course.
Alright. The ESC idea originates from the topic linked above and I thought "well, let's do a combined a11y"-PR ;)
Will you cherry pick Commit cfe5d89, or should I create a new Merge Request with just that commit or will you transfer it manually?
Since we're communicating and talking about accessibility: ryancramerdesign/ProcessWire#1758 - here's my PR from the old repo with some subtle changes to inbuilt site profiles. Should I recreate the same PR for this very repo or is it also a manual transfer thing?
Either way: thanks for your great work!
No need to submit another, I can cherry pick no problem. We are using a CLA with this new repo, would you mind completing the second bullet point from the PR section of the CONTRIBUTING.md file? https://github.com/processwire/processwire/blob/master/CONTRIBUTING.md#pull-requests-prs
For the other PR, if it's easy to create a new PR for it here, then great. If not, then no worries I can make the adjustments without a PR.