New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comments regarding FieldtypeDecimal #130

Open
wants to merge 1 commit into
base: dev
from

Conversation

Projects
None yet
2 participants
@BernhardBaumrock

BernhardBaumrock commented Nov 29, 2018

No description provided.

@LostKobrakai

This comment has been minimized.

Contributor

LostKobrakai commented Nov 29, 2018

I really like what you did there, but would tackle it a bit differently. Instead of promoting the decimal fieldtype directly we need to inform the user about all the potential backdraws floats have first. Only after that's done the user can make an informed decision and this is where we can link to the decimal fieldtype.

Currently I don't feel like a user not aware of the difference between floats and decimals could make much sense about why this is there without doing the work and clicking all the links.

I also don't feel like the note is needed in that place. Why and how floats work differently then one might expect can be part of external information we link to. Important is that we warn about the issues of floats, explanation can happen elsewhere.

@BernhardBaumrock

This comment has been minimized.

BernhardBaumrock commented Nov 29, 2018

Totally agree, I wanted to make a first step :) I'm not well versed with benefits and drawbacks of those fieldtypes, so I'd happy to read someone's explanations. Maybe this would be a good reason for a dedicated blog post. They'll be part of the docs in the near future, so it would definitely make sense. Then we could just link to that blogpost (as official and compact resource) from all related Fieldtypes with a comment (int, float, decimal).

@LostKobrakai

This comment has been minimized.

Contributor

LostKobrakai commented Nov 29, 2018

http://0.30000000000000004.com/ might be a good resource so link to

@BernhardBaumrock

This comment has been minimized.

BernhardBaumrock commented Nov 29, 2018

I'd vote for a human readable blogpost :D And add your link there ;)

@LostKobrakai

This comment has been minimized.

Contributor

LostKobrakai commented Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment