Remove Optimizer #61
Merged
Remove Optimizer #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ok, Optimizer is not working and is causing multiple problems. Until we come up with a better solution, I think it is best to remove Optimizer so that we can start accepting ActiveRecord objects that have relations with other objects. We should re-introduce Optimizer at a later time when we have a working solution.
Merged
mcclayton
approved these changes
Jan 19, 2018
AllPurposeName
approved these changes
Jan 19, 2018
There was a problem hiding this comment.
I'd like to keep in mind this feature as a cornerstone to what power Blueprinter can have. Having said that, this PR is necessary. As we discovered when we extracted this class in the first place, it is very hard to even test with the current state of Blueprinter and probably needs an optimization use case driving it's design rather than throwing a lot of mud against the wall and hoping it sticks.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, Optimizer is not working and is causing multiple problems.
Until we come up with a better solution, I think it is best to remove
Optimizer so that we can start accepting ActiveRecord objects that
have relations with other objects.
We should re-introduce Optimizer at a later time when we have a working
solution.