New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gemfile.lock and move dependencies to gemspec #97

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
3 participants
@hugopeixoto
Contributor

hugopeixoto commented Oct 3, 2018

Hi there! Let me know if the following changes make sense:

From what I understand, it's usually not recommended to commit Gemfile.lock[1].
This PR removes it and adds it to gitignore.

Additionally, a dev dependency was added to the Gemfile instead of being added to the gemspec.
This PR also moves that dependency.

[1] https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

@philipqnguyen

Thanks for the PR @hugopeixoto !

So circleci specs are failing with the following error:

NameError:
  uninitialized constant FactoryBot
# ./spec/factories/model_factories.rb:1:in `<top (required)>'
# ./spec/integrations/base_spec.rb:4:in `require_relative'
# ./spec/integrations/base_spec.rb:4:in `<top (required)>'

You should be able to fix this by adding require factory_bot at the top of spec/factories/model_factories.rb

Show outdated Hide outdated blueprinter.gemspec Outdated
@hugopeixoto

This comment has been minimized.

Show comment
Hide comment
@hugopeixoto

hugopeixoto Oct 3, 2018

Contributor

I was trying to figure out why factorybot wasn't being detected. Kind of surprised it works locally, though. I'll add the require, thanks for the pointer

Contributor

hugopeixoto commented Oct 3, 2018

I was trying to figure out why factorybot wasn't being detected. Kind of surprised it works locally, though. I'll add the require, thanks for the pointer

@dlcarter

Looks good, thanks for this! 👍

@philipqnguyen philipqnguyen merged commit e829411 into procore:master Oct 3, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment