GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I've upgraded to circleci 2.0 and included tests for multiple ruby versions.
I'm having some issues when running the benchmark tests. Ruby 2.2 tends to fail the linear test (~98%). We might need to increase the threshold to make this pass.
Upgrade to circleci 2.0
Thanks for tackling #98 it looks good!
Yes let's bring the threshold to 98, we can adjust it again if it still becomes a problem at 98 in future tests.
Reduce benchmark threshold
ruby2.2 was randomly failing just below the 99% mark.
This reduces the threshold to 98%.
I reduced it to 98%, should be ready to go
Looks good! 👍