New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to circleci 2.0 #99

Merged
merged 2 commits into from Oct 10, 2018

Conversation

Projects
None yet
3 participants
@hugopeixoto
Contributor

hugopeixoto commented Oct 9, 2018

I've upgraded to circleci 2.0 and included tests for multiple ruby versions.

I'm having some issues when running the benchmark tests. Ruby 2.2 tends to fail the linear test (~98%). We might need to increase the threshold to make this pass.

@philipqnguyen

This comment has been minimized.

Show comment
Hide comment
@philipqnguyen

philipqnguyen Oct 9, 2018

Collaborator

Thanks for tackling #98 it looks good!

Yes let's bring the threshold to 98, we can adjust it again if it still becomes a problem at 98 in future tests.

Collaborator

philipqnguyen commented Oct 9, 2018

Thanks for tackling #98 it looks good!

Yes let's bring the threshold to 98, we can adjust it again if it still becomes a problem at 98 in future tests.

Reduce benchmark threshold
ruby2.2 was randomly failing just below the 99% mark.
This reduces the threshold to 98%.
@hugopeixoto

This comment has been minimized.

Show comment
Hide comment
@hugopeixoto

hugopeixoto Oct 10, 2018

Contributor

I reduced it to 98%, should be ready to go

Contributor

hugopeixoto commented Oct 10, 2018

I reduced it to 98%, should be ready to go

@dlcarter

Looks good! 👍

@philipqnguyen philipqnguyen merged commit 904b323 into procore:master Oct 10, 2018

4 checks passed

ci/circleci: ruby-2.2 Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.3 Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4 Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment