New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish latest version #178

Closed
sugarshin opened this Issue May 24, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@sugarshin
Copy link

sugarshin commented May 24, 2017

HI,

Available this warning when npm installation.

warning "chai-enzyme@0.7.0" has unmet peer dependency "react-addons-test-utils@^0.14.0 || ^15.0.0-0".

Please latest version publish to npm .

@ayrton

This comment has been minimized.

Copy link
Member

ayrton commented May 24, 2017

Related PR #166

I think you now have to specify react-addons-test-utils as a dev dependency

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented May 24, 2017

Yes, this is intended, since it's a requirement of enzyme's.

@ljharb ljharb closed this May 24, 2017

@ayrton

This comment has been minimized.

Copy link
Member

ayrton commented May 24, 2017

@ljharb do we have to revert #166 or is everything all good right now?

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented May 24, 2017

I don't see why; the only way someone could run into this is if they were not explicitly depending on things enzyme requires. This is a bug fix.

@sugarshin

This comment has been minimized.

Copy link

sugarshin commented May 24, 2017

I mean master branch and latest version published to npm are different.

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented May 24, 2017

v0.7.0 was released 2 days ago; 3081e30 is the only commit not yet released.

Another publish of v0.7.1 would be fine, sure.

@ayrton

This comment has been minimized.

Copy link
Member

ayrton commented May 24, 2017

Released 0.7.1 just now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment