From cc980f5200b5fc2a3edffd80880f856ac346fab1 Mon Sep 17 00:00:00 2001 From: Tony R Quilkey Date: Thu, 3 Jan 2013 11:12:44 +1100 Subject: [PATCH 1/2] Remove useless test case. --- lib/Proem/Routing/Tests/RouteAbstractTest.php | 44 ------------------- 1 file changed, 44 deletions(-) delete mode 100644 lib/Proem/Routing/Tests/RouteAbstractTest.php diff --git a/lib/Proem/Routing/Tests/RouteAbstractTest.php b/lib/Proem/Routing/Tests/RouteAbstractTest.php deleted file mode 100644 index 642f6ed..0000000 --- a/lib/Proem/Routing/Tests/RouteAbstractTest.php +++ /dev/null @@ -1,44 +0,0 @@ - - * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to deal - * in the Software without restriction, including without limitation the rights - * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell - * copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, - * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN - * THE SOFTWARE. - */ - -namespace Proem\Routing\Tests; - -use \Mockery as m; - -class RouteAbstractTest extends \PHPUnit_Framework_TestCase -{ - public function testCanInstantiate() - { - $this->assertInstanceOf('Proem\Routing\RouteInterface', m::mock('Proem\Routing\RouteAbstract')); - } - - public function testCanProcessCallback() - { - $route = m::mock('Proem\Routing\RouteAbstract[process]', [['callback' => function() { return true; }]]); - $this->assertTrue($route->hasCallback()); - $this->assertTrue(call_user_func($route->getCallback())); - } -} From 785e5ed3bd8069d07dea80eb49321c562f7916a2 Mon Sep 17 00:00:00 2001 From: Tony R Quilkey Date: Thu, 3 Jan 2013 11:12:57 +1100 Subject: [PATCH 2/2] Update sniff task to ignore Tests directories. --- Phakefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Phakefile b/Phakefile index 3b4913c..a3bdcba 100644 --- a/Phakefile +++ b/Phakefile @@ -36,7 +36,7 @@ group('dev', function() { desc('Sniff code for PSR-1/2'); task('sniff', function ($args) { chdir(realpath(__DIR__)); - system('vendor/bin/phpcs -a --standard=PSR2 lib/'); + system('vendor/bin/phpcs -a --ignore=/Tests/* --standard=PSR2 lib/'); }); desc('Build the Phar archive');