From f7f27f53d39b369fd41ad626d8b13fd497ef8ff1 Mon Sep 17 00:00:00 2001 From: Kieran Date: Tue, 26 Nov 2024 15:48:29 +0000 Subject: [PATCH 1/2] Test PHP 8.4 --- .github/workflows/php-tests.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/php-tests.yml b/.github/workflows/php-tests.yml index a102434c..9447d363 100644 --- a/.github/workflows/php-tests.yml +++ b/.github/workflows/php-tests.yml @@ -13,10 +13,14 @@ jobs: strategy: matrix: laravel: ['9', '10', '11'] - php: ['8.1', '8.2', '8.3'] + php: ['8.1', '8.2', '8.3', '8.4'] exclude: - laravel: '11' php: '8.1' + - laravel: '9' + php: '8.4' + - laravel: '10' + php: '8.4' name: PHP ${{ matrix.php }} Laravel ${{ matrix.laravel }} From 4e13fc1f9f386b34f8e6ee697dd95b39d6394a1f Mon Sep 17 00:00:00 2001 From: Kieran Date: Tue, 26 Nov 2024 15:51:45 +0000 Subject: [PATCH 2/2] Update JsValidationServiceProviderTest.php --- tests/JsValidationServiceProviderTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/JsValidationServiceProviderTest.php b/tests/JsValidationServiceProviderTest.php index 0de17301..c9bb5307 100644 --- a/tests/JsValidationServiceProviderTest.php +++ b/tests/JsValidationServiceProviderTest.php @@ -111,7 +111,7 @@ public function testRegister() $mock->register(); } - protected function assertConfigMerged(string $file, string $configKey = null): void + protected function assertConfigMerged(string $file, ?string $configKey = null): void { $configKey ??= Str::of($file)->beforeLast('.php')->afterLast('/')->afterLast('\\')->toString();