Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Message carbons are not logged to chat log file #1181
In the chat logs messages sent from Profanity along with messages sent by other clients (carbons) should be logged into the log file.
Chat logs contain messages received and messages sent by the Profanity client, but do not include messages sent by the user's other clients. I am using OMEMO encryption in the chats that I experience this behavior (/omemo log on is enabled).
Steps to Reproduce (for bugs)
Profanity, version 0.7.0
System: Ubuntu Linux 18.04
glib2.0 Version: 2.56.4-0ubuntu0.18.04.4
@jubalh This still doesn't seem to work for me. I did a git pull from master this evening as you can see from the version number below. Messages sent by me using profanity to users on my roster are logged, but the messages sent from Conversations are not logged (but do show on the screen).
Enabling and disabling OMEMO made no difference.
I just had a quick look at my logfiles:
So it seems logging is broken. Any special use cases you like to be tested?
Gosh. There is a lot of stuff wrong here I think.
There we have
Also we use
@jubalh I started testing this tonight. It seems to be working so far. Messages sent from my other client (Conversations) seem to be appearing in my logs now. I will comment again if I find something not working with this. Thanks!
Unrelated I think, I did find a message that appeared in Profanity from a contact that did not get logged into the log file (while I was testing). I can't reproduce it (the following messages were logged). If I can find how to reproduce it, I'll open a separate issue report.
@weiss is it possible that messages to a MUC from another client are not also sent via Carbons?
I do this because we log the message already as an outgoing MUC message here: https://github.com/profanity-im/profanity/blob/master/src/event/client_events.c#L346
We log the outgoing one so we have an easier time with OMEMO.
@paulfariello is it OMEMO wise possible to stop logging outgoing MUC messages and only log incoming ones?
In this case we could remove outgoing logging and just log incoming stuff.
You could add an origin ID to track your own messages. (Or just the normal message ID, but old servers might mess with that: XEP-0045 didn't require MUC services to maintain the original message ID until revision 1.31 from 2018.)