Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support XEP-0359: Unique and Stable Stanza IDs #1207

Closed
jubalh opened this issue Oct 16, 2019 · 2 comments
Closed

Support XEP-0359: Unique and Stable Stanza IDs #1207

jubalh opened this issue Oct 16, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@jubalh
Copy link
Member

@jubalh jubalh commented Oct 16, 2019

XEP-0359

This will help us identify which messages in a MUC were sent by us (#1201), and also will be useful later when we implement XEP-0313 MAM (#660) and XEP-0308 Last Message Correction (#805) too.

@jubalh jubalh added the feature label Oct 16, 2019
@jubalh jubalh added this to the 0.8.0 milestone Oct 16, 2019
@jubalh jubalh self-assigned this Oct 16, 2019
jubalh added a commit to jubalh/profanity that referenced this issue Oct 17, 2019
So far only with dummy value.
We will need an identifier that we can hash together with a message ID
and put in as the origin-id.
So when we receive message we can unsplit it and see if it was sent from
this client.

Regards profanity-im#1207
jubalh added a commit to jubalh/profanity that referenced this issue Oct 17, 2019
And rename `instance` to `identifier`.

Regards profanity-im#1207
jubalh added a commit to jubalh/profanity that referenced this issue Oct 17, 2019
This will be needed so that we can later detect if messages (origin-in)
was sent by us.

Regards profanity-im#1207
@jubalh jubalh mentioned this issue Oct 18, 2019
@jubalh jubalh closed this in 3308366 Oct 21, 2019
@jubalh

This comment has been minimized.

Copy link
Member Author

@jubalh jubalh commented Oct 21, 2019

We don't implement yet, because we don't use it until we have MAM.

@jubalh

This comment has been minimized.

Copy link
Member Author

@jubalh jubalh commented Oct 21, 2019

#1207 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.