New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profanity shows old messages as new when connecting to some MUC #1254
Comments
So far we got the first delay with a from that comes from the server. This way we know it's MUC history. Now we take the first time stamp we actually find. Which is likely the one being added first. And should contain the correct time to display. It would be nicer to actually compare the dates though. Regards #1254
@misaflo can you please test with latest master? |
Yes, no change: the datetime is still wrong (datetime of the connection). |
This reverts commit ef00b10. According to reply by user in #1254 (comment) it didn't help.
So far we saved the timestamp which also had the `from`. But we need this only to find out whether it's MUC history. For displaying we should use the oldest delay timestamp. Also in 61f6696#diff-4926fd4577a336bd3eb240f8104a5c5bL837 a error was introduced. Before we saved the timestamp in all cases. And only if timestamp AND from was given we went into MUC history case. Normal timestamp saving was not done anymore only if it also had a from attribute. Regards #1254
@misaflo can you test with latest master again? |
No change :-( |
Can you please describe again what is happening and how you test this? |
Do you mean that messages that were sent while you were offline (to a MUC) are later displayed as regular messages and not as MUC history? Or are you saying the date/time of all MUC messages is wrong? Also does this only happen to you on that openfire server? |
I joining some MUC when connecting to my account. For test this, I just |
|
https://xmpp.org/extensions/xep-0045.html#enter-history sais "The 'from' attribute MUST be set to the JID of the room itself."
has Maybe an openfire problem? |
I created a bug for openfire: https://discourse.igniterealtime.org/t/maybe-muc-history-bug/87165 |
Through this issue we fixed some problems anyways :)
|
I'll close this issue because I think it's an Openfire bug. Further discussion hopefully happens on the above mentioned bug in the openfire tracker. |
Expected Behavior
Old messages are not shown as new but are in the right place of the timeline.
Current Behavior
In some MUC (on server running Openfire 4.5.0), after connect old messages are shown as just received with the current date and time (not in Profanity MUC).
Context
Here some log (
profanity --log=DEBUG
):There is:
stamp="2020-01-15T18:21:58.455Z"
(witch is the right hour, 18:21:58).But in profanity I see the hour of the connection to the MUC (21:29:11).
This bug concern dev version (and does not occur in the stable release 0.7.1).
Environment
Tested on Arch Linux and Debian Buster.
The text was updated successfully, but these errors were encountered: