Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get profile API to allow merging profiles by IDs #76

Merged
merged 3 commits into from Mar 7, 2020

Conversation

@narqo
Copy link
Member

narqo commented Mar 7, 2020

The PR updates /api/0/profiles API to allow passing multiple profile IDs (using + as ids' separator):

GET /api/0/profiles/id1+id2+id3

The API returns a single profile, that contains all profiles merged into one.

This change effectively makes /api/0/profiles/merge?service=svc1 an alias for

> GET /api/profiles?service=svc1 | jq '.body | .[] | .id'
id1
id2
id3

> GET /api/profiles/id1+id2+id3
narqo added 3 commits Mar 7, 2020
GET /api/0/profiles/pid1+pid2+pid3

Also allow passing profile id in urlencoded form.

Also fix typo in pkg/storage.Storage's stub.
@narqo narqo merged commit 5ab457f into master Mar 7, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@narqo narqo deleted the profiles-merge-by-id branch Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.