Clarified '.gitignore' description, fixed typo, and added '%d' to 'git log' table #350

Closed
wants to merge 5 commits into
from

Projects

None yet

4 participants

@camwright
Contributor

Just clarified the description of .gitignore, fixed a typo in "Moving Files", and added %d to the formatting options for git log.

@camwright camwright closed this Jan 9, 2013
@camwright camwright reopened this Jan 9, 2013
@jnavila jnavila commented on the diff Jan 9, 2013
en/02-git-basics/01-chapter2.markdown
@@ -407,7 +407,7 @@ However, this is equivalent to running something like this:
$ git rm README.txt
$ git add README
-Git figures out that it’s a rename implicitly, so it doesn’t matter if you rename a file that way or with the `mv` command. The only real difference is that `mv` is one command instead of three — it’s a convenience function. More important, you can use any tool you like to rename a file, and address the add/rm later, before you commit.
+Git figures out that it’s a rename implicitly, so it doesn’t matter if you rename a file that way or with the `mv` command. The only real difference is that `mv` is one command instead of three — it’s a convenience function. More importantly, you can use any tool you like to rename a file, and address the add/rm later, before you commit.
@jnavila
jnavila Jan 9, 2013 Member

This fix seems a bit pedantic. Both forms are acceptable.

@GArik
Contributor
GArik commented Jan 9, 2013

- you can create a file listing patterns to match them named .gitignore

  • you can create a file named .gitignore describing these unwanted files

The first variant is more clear to me.

- More important,

  • More importantly,

Ok.

+ %d Ref names

You can't add this here. References are discussed later in the book.

@jnavila
Member
jnavila commented Jan 9, 2013

Concerning .gitignore, I fully agree with @GArik. The original sentence is more precise. What is bothering you in it?

For the ref names format field, this is indeed very useful. Maybe reword it to "branch tip names" and add a callout to the chapter 3.

@camwright
Contributor

Only that it doesn't really roll off the tongue.

I believe, gramatically, importantly is correct. An adverb belongs here, not an adjective.

Ok, will do.

@schacon
Member
schacon commented Oct 22, 2014

I really try not to introduce things before we talk about them whenever I can. I figure that once people are introduced to the concept of the pretty printing in log they will have to pull it up in the man page to reference how to format it later anyhow. The point of the section is to let people know that the log formatting is an option, not what all the options are.

@schacon schacon closed this Oct 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment