08-git-and-other-scms: Fix command for svn author names #380

Merged
merged 1 commit into from Mar 1, 2013

Conversation

Projects
None yet
3 participants
Contributor

ckorn commented Mar 1, 2013

The command for creating the svn user list is wrong.
It does not output the list in the format which is required
by git-svn clone.
This issue has already been fixed for some languages in
commit 758d464.
This patch applies this fix for all languages.
Additionally the output is directly written into the file
users.txt where it is expected to be according to the
subsequent git-svn clone command.

Christoph Korn 08-git-and-other-scms: Fix command for svn author names
The command for creating the svn user list is wrong.
It does not output the list in the format which is required
by git-svn clone.
This issue has already been fixed for some languages in
commit 758d464.
This patch applies this fix for all languages.
Additionally the output is directly written into the file
users.txt where it is expected to be according to the
subsequent git-svn clone command.
2427098
Member

jnavila commented Mar 1, 2013

Merged. Thanks!

@jnavila jnavila added a commit that referenced this pull request Mar 1, 2013

@jnavila jnavila Merge pull request #380 from ckorn/users.txt
08-git-and-other-scms: Fix command for svn author names
9b390c2

@jnavila jnavila merged commit 9b390c2 into progit:master Mar 1, 2013

Contributor

GArik commented Mar 5, 2013

Additionally the output is directly written into the file users.txt where it is expected to be according to the subsequent git-svn clone command.

What for? The paragraph below says "redirect that output into your users.txt file". Do you think that a reader don't know how to redirect output into a file?
If you change some code snippet then change its description accordingly!

Contributor

ckorn commented Mar 5, 2013

Hum, I had a look at the German translation where it says "Anschließend wird die Ausgabe in die Datei users.txt umgeleitet" which means "Afterwards the output is redirected to the file users.txt file".
So I assumed the command should also do this.
But you are correct in the English (aka the original) version it commands the user to do so by himself.
Do you want the German paragraph to match the English meaning better and then to remove the redirect to users.txt again?

Member

jnavila commented Mar 5, 2013

I am not against describing the action and adding the redirect in the command. Not all users know how to redirect the output of a command into a file.

Contributor

GArik commented Mar 6, 2013

Do you want <...> to remove the redirect to users.txt again?

Yep. I do think that your changeset is a regression.
For me it makes perfect sense to first look at the output of this code snippet and then if it looks fine redirect it to users.txt.

Contributor

ckorn commented Mar 6, 2013

Please have a look at merge request #381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment