[zh]Fix markdown syntax typo #385

Merged
merged 2 commits into from Mar 13, 2013

Conversation

Projects
None yet
3 participants
Contributor

reyesyang commented Mar 13, 2013

No description provided.

Member

jnavila commented Mar 13, 2013

I do not understand the purpose of this fix. Can you explain it?

Contributor

reyesyang commented Mar 13, 2013

_跟踪分支(tracking branch) should be _跟踪分支_(tracking branch), the original translation lost a '_' before '(tracking branch)'

Member

jnavila commented Mar 13, 2013

Is it working? if I refer to https://github.com/reyesyang/progit/blob/b5401fd976ea93bc76addefb6be5573b7c0fb8f8/zh/03-git-branching/01-chapter3.markdown the underscores are not handled correctly (should be bold). The markdown engine expects the underscores to be surrounded by spaces.

It is not correctly rendered in pdf either on my box. Can you check whether you can add spaces and if it affects the rendering?

Contributor

GArik commented Mar 13, 2013

Underscores give italic, asterisks give bold :)

Member

jnavila commented Mar 13, 2013

Well, right now, that only gives underscores...

@reyesyang reyesyang Add space before and after underscore
Add space before and after underscore to fix markdown italic render
87da431
Contributor

reyesyang commented Mar 13, 2013

Thanks for your correction, I have updated the code. :)

@jnavila jnavila added a commit that referenced this pull request Mar 13, 2013

@jnavila jnavila Merge pull request #385 from reyesyang/master
[zh]Fix markdown syntax typo
24bff5e

@jnavila jnavila merged commit 24bff5e into progit:master Mar 13, 2013

Member

jnavila commented Mar 13, 2013

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment