Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting a detail of the preamble of the "Project Scholarship" #1930

Closed
JimmyMedeiros82 opened this issue Nov 10, 2020 · 6 comments · Fixed by #2046
Closed

Correcting a detail of the preamble of the "Project Scholarship" #1930

JimmyMedeiros82 opened this issue Nov 10, 2020 · 6 comments · Fixed by #2046
Assignees

Comments

@JimmyMedeiros82
Copy link
Contributor

Hello, following the on-board! The preamble to the "Project Scholarship" page reads like this:

"The project team and members of the wider community are involved in a number of scholarly initiatives related to our work here at The Programming Historian. These include events, journal articles, reviews (of us by the community), and posters. If you are conducting academic research using this project please Sarah Melton."

It says "please Sarah Melton." but it would be better if it were "If you are conducting academic research using this project please contact Sarah Melton.".

NOTE: This is part of a test issue/pull-request sequence to support project documentation.

@DanielAlvesLABDH
Copy link
Contributor

Welcome @JimmyMedeiros82 ! I think your proposal is fine. I agree with the correction to be made.

@JoshuaGOB
Copy link
Contributor

Hi @JimmyMedeiros82 Please create a pull requests making the correction in the appropriate file. Se você precisar de ajuda com o processo específico para isso, você pode fazer perguntas no Github ou por e-mail.

@DanielAlvesLABDH
Copy link
Contributor

Olá @JimmyMedeiros82! O @JoshuaGOB ou eu podemos ajudar na conclusão desta questão. Estamos quase a lançar o site, era bom ter este processo completo. Abraço

@JimmyMedeiros82
Copy link
Contributor Author

Processo finalizado, correto? Posso fechar, @DanielAlvesLABDH ?

@DanielAlvesLABDH
Copy link
Contributor

Não sei. Você chegou a fazer a alteração no ficheiro e a abrir o pull request?

@JimmyMedeiros82
Copy link
Contributor Author

I made the pull request now.
I thought I did that a few months ago

@JimmyMedeiros82 JimmyMedeiros82 linked a pull request Feb 22, 2021 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants