-
Notifications
You must be signed in to change notification settings - Fork 229
Drjwbaker donations - updates FR nous-soutenir page #1535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add donation wording
final light edit to donate section
fix typo line 31
updates FR page
drjwbaker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
@spapastamkou For some reason this isn't showing on the live site https://programminghistorian.org/fr/nous-soutenir#donations @programminghistorian/technical-team: any ideas? |
|
@mdlincoln - I tried restarting the build on Travis and dumping my own cache/hard reloading, but neither got the thing to show up even though it's in the gh-pages repo. Do you have any ideas? |
|
To raise this pull request, I restored James' branch that had already been merged in PR #1504, updated it and then made a commit to it with the changes for the FR page. Maybe I should have created a separate branch, perhaps the problem comes from there? |
|
@walshbr @spapastamkou Do we just need to open a new PR to solve this problem? |
|
I am not very sure as to what to do but it is the only thing I can think of. I could try (this evening), @drjwbaker |
|
That last sentence in that thing you linked to @spapastamkou didn't sound promising - "Restoring the branch of a merged pull request will not trigger a build, nor will pushing a new commit to a branch that has already been merged." But I think merging a new PR should trigger a new build, and, since the file is already as you want it in the gh-pages repository it should get pulled in. I just merged #1548 since it was ready to see if that fixes the issue here. I'll report back. |
|
@drjwbaker @spapastamkou - I think that did it. Looks like https://programminghistorian.org/fr/nous-soutenir#donations is showing up on the main site now but ping me if it does not? |
|
Bingo |
Updates FR 'support us' (nous soutenir) page as per merged #1504