Font selection per language#19
Merged
Merged
Conversation
programnoir
added
game ui/ux
Owner
Author
|
Still lacking font sizing options. Currently debating how to implement this. |
Trying to improve performance but still getting lag. Asking community.
Improves runtime performance
Adds asynchronous timer calls
Asynchronous calls only need one thread.
Unifies and caps font sizes, fixes container issues revealed by new font resizing features, automatically caps font sizing according to game scale
Replaces button based increment changes with a spinbox that can be revealed with a button. Likely needs debugging before using a code style guidelines pass.
Proper value set but not reflected in the text of the lineedit in the spinbox.
Owner
Author
|
Everything looks good. The .gitignore wasn't configured to filter out the .import files in the font assets folder. I plan on asking if this is necessary later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds font selection that is grouped according to language. Uses a small, expandable handful of available fonts per language.