fix(desktop): wire icon.ico into bundle config for Windows builds#19
Merged
Conversation
The Windows job in the v0.1.1-test dry-run failed at the bundling step: failed to bundle project `Couldn't find a .ico icon` `packages/desktop/src-tauri/icons/icon.ico` already exists on disk — the bundle config just listed `icons/icon.png` and nothing else, so the Windows bundler had no .ico path to consume and the macOS bundler fell back to converting the PNG to .icns at build time. Now the icon array follows Tauri's per-platform convention: sized PNGs for Linux deb/AppImage, .icns for macOS, .ico for Windows. Tauri picks the right one per target. Co-Authored-By: WOZCODE <contact@withwoz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Windows job in the `v0.1.1-test` dry-run failed at the bundling step:
```
failed to bundle project `Couldn't find a .ico icon`
```
`packages/desktop/src-tauri/icons/icon.ico` already exists on disk — the bundle config just listed `icons/icon.png` and nothing else, so the Windows bundler had no `.ico` path to consume.
Changes
`tauri.conf.json` bundle.icon array now follows Tauri's per-platform convention:
```json
"icon": [
"icons/32x32.png",
"icons/128x128.png",
"icons/128x128@2x.png",
"icons/icon.icns",
"icons/icon.ico"
]
```
Tauri picks the right one per target: sized PNGs for Linux deb/AppImage, `.icns` for macOS, `.ico` for Windows.
Test plan
🧙 Built with WOZCODE