fix(landing): point header Features link at /#features#41
Merged
Conversation
…ge fragment The header renders on every route, but the Features nav link was a bare `#features`. On any sub-page (/docs, /privacy, /changelog) the browser resolved it against the current path — e.g. /docs/#features — which has no such anchor, so clicking Features did nothing instead of returning to the home page's Features section. Made it absolute (`/#features`) so it always targets the section on the home page. Added a header test covering the Features anchor + the other nav routes. Co-Authored-By: WOZCODE <contact@withwoz.com>
|
Landing preview will be available at https://bluemacaw.com/previews/pr-41/ once AWS infra lands (Plan D). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The header renders on every route, but the Features nav link was a bare
#features. On any sub-page (/docs,/privacy,/changelog) the browser resolved it against the current path — e.g./docs/#features— which has no such anchor, so clicking Features did nothing instead of returning to the home page's Features section.Made it absolute (
/#features) so it always targets the Features section on the home page.Test plan
header.test.tsx: Features →/#features; Docs/Privacy/Changelog routes intact🧙 Built with WOZCODE