Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #23 / Switch to Hugo's built-in Menu System #26

Merged
merged 2 commits into from Mar 5, 2017
Merged

Fix #23 / Switch to Hugo's built-in Menu System #26

merged 2 commits into from Mar 5, 2017

Conversation

@key-amb
Copy link
Collaborator

@key-amb key-amb commented Mar 5, 2017

The Hugo's Menu System https://gohugo.io/extras/menus/ worked with no problem.

I will release this change soon.

cc: @pedromorgan @ethanmad

Just to inform this change.

@key-amb key-amb merged commit 2290ded into master Mar 5, 2017
@key-amb key-amb deleted the feature/menu branch Mar 5, 2017
@key-amb
Copy link
Collaborator Author

@key-amb key-amb commented Mar 5, 2017

Just released as v1.3.0

@ethanmad
Copy link

@ethanmad ethanmad commented Mar 5, 2017

Thank you for the change and for ccing me. I will update the theme in my fork hopefully later this week. Aside from merging your two commits in this PR and updating my config.toml, I don't need to do anything, correct?

@key-amb
Copy link
Collaborator Author

@key-amb key-amb commented Mar 5, 2017

Thank you for the change and for ccing me. I will update the theme in my fork hopefully later this week. Aside from merging your two commits in this PR and updating my config.toml, I don't need to do anything, correct?

I took a glance for your club-theme and UMFC-website and I think it works well.
Though I can't promise it.
Good luck!

@ethanmad

This comment has been minimized.

Copy link

@ethanmad ethanmad commented on layouts/partials/header.html in 5b14e40 Jul 26, 2018

This isn't working for me since updating to include this commit (among other things). See for example http://umich.edu/~fencing/results/. As far as I can tell, my theme and site don't have meaningful differences with yours:

Would you mind helping me fix this please? It may be due to my base domain not being the root domain, but the Hugo documentation seems to account for such issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants