Skip to content

Fixing ruby heroku buildpack #58

Merged
merged 2 commits into from Nov 17, 2013

2 participants

@nolman
nolman commented Nov 14, 2013

The build pack release step for the heroku-buildpack-ruby is currently broken. It fails to generate a .release file which manifests as the following exception when attempting to YAML load the release file.


/usr/lib/ruby/1.9.1/psych.rb:297:in `initialize': no implicit conversion from nil to integer (TypeError)
from /usr/lib/ruby/1.9.1/psych.rb:297:in `open'
from /usr/lib/ruby/1.9.1/psych.rb:297:in `load_file'

Looking at the heroku buildpack documentation I believe this is the correct way to invoke release (bin/release $BUILD_DIR)

@progrium
Owner

I thought we pulled something like this recently. Also, there seems to be a conflict. Can you rebase?

@nolman
nolman commented Nov 16, 2013

Rebased, sorry about that. Removed the extra param from the ./bin/release call.

@progrium
Owner

So you're right, this is how you properly call release, but does this fix the problem with the ruby buildpack? If so, how?

@nolman
nolman commented Nov 16, 2013

Ya the other pull request did fix the ruby buildpack, I was based off an old version of master. Did you want me to update the commit msg or pull request details?

@progrium progrium merged commit 79cf680 into progrium:master Nov 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.