Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fixing ruby heroku buildpack #58

Merged
merged 2 commits into from

2 participants

@nolman

The build pack release step for the heroku-buildpack-ruby is currently broken. It fails to generate a .release file which manifests as the following exception when attempting to YAML load the release file.


/usr/lib/ruby/1.9.1/psych.rb:297:in `initialize': no implicit conversion from nil to integer (TypeError)
from /usr/lib/ruby/1.9.1/psych.rb:297:in `open'
from /usr/lib/ruby/1.9.1/psych.rb:297:in `load_file'

Looking at the heroku buildpack documentation I believe this is the correct way to invoke release (bin/release $BUILD_DIR)

@progrium
Owner

I thought we pulled something like this recently. Also, there seems to be a conflict. Can you rebase?

@nolman

Rebased, sorry about that. Removed the extra param from the ./bin/release call.

@progrium
Owner

So you're right, this is how you properly call release, but does this fix the problem with the ruby buildpack? If so, how?

@nolman

Ya the other pull request did fix the ruby buildpack, I was based off an old version of master. Did you want me to update the commit msg or pull request details?

@progrium progrium merged commit 79cf680 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 16, 2013
  1. @nolman
  2. @nolman

    updating authors

    nolman authored
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 1 deletion.
  1. +1 −0  AUTHORS
  2. +2 −1  stack/builder
View
1  AUTHORS
@@ -7,4 +7,5 @@ Felipe Coury <felipe.coury@gmail.com>
Jeff Lindsay <progrium@gmail.com>
Luke Closs <me@luk.ec>
Mike Park <mikep@quake.net>
+Nolan Evans <nolane@gmail.com>
Richard North <rich.north@gmail.com>
View
3  stack/builder
@@ -43,7 +43,8 @@ export REQUEST_ID=$(openssl rand -base64 32)
$selected_buildpack/bin/compile "$build_root" "$cache_root"
echo "-----> Discovering process types"
-$selected_buildpack/bin/release "$build_root" "$cache_root" > /build/app/.release
+
+$selected_buildpack/bin/release "$build_root" > /build/app/.release
if [[ -f "$build_root/Procfile" ]]; then
types=$(ruby -e "require 'yaml';puts YAML.load_file('$build_root/Procfile').keys().join(', ')")
Something went wrong with that request. Please try again.