Lots of goodies #2

Merged
merged 10 commits into from Nov 12, 2013

Conversation

Projects
None yet
2 participants
@fgrehm
Contributor

fgrehm commented Nov 12, 2013

Here we go, my first Golang PR EVAH 馃槂 馃巻

What's on this PR:

  • Some basic instructions for hacking on the project
  • Support for building docs for specific revisions with repo~ref
  • "Just enough README" for those who reaches the project on GitHub
  • Error out if ACCESS_TOKEN is not set
  • go fmt

progrium added a commit that referenced this pull request Nov 12, 2013

@progrium progrium merged commit 14f2976 into progrium:master Nov 12, 2013

+
+ bodyStr := string(body)
+ // Ajust relative links for specific git revisions
+ // FIXME: This doesn't handle relative links on the template / layout,

This comment has been minimized.

@fgrehm

fgrehm Nov 12, 2013

Contributor

Oh, I got excited about sending the PR and forgot to mention this. I'm not sure what's the best approach for handling links relative to the current git branch on the generated HTML so I hacked together this regex to at least adjust links inside the markdown :P

@fgrehm

fgrehm Nov 12, 2013

Contributor

Oh, I got excited about sending the PR and forgot to mention this. I'm not sure what's the best approach for handling links relative to the current git branch on the generated HTML so I hacked together this regex to at least adjust links inside the markdown :P

This comment has been minimized.

@progrium

progrium Nov 12, 2013

Owner

This is pretty good. We could expose the ref to the template, but since there's no logic it makes it difficult to handle the default master case vs non-master. This seems good enough for now.

@progrium

progrium Nov 12, 2013

Owner

This is pretty good. We could expose the ref to the template, but since there's no logic it makes it difficult to handle the default master case vs non-master. This seems good enough for now.

@progrium

This comment has been minimized.

Show comment
Hide comment
@progrium

progrium Nov 12, 2013

Owner

Pulled and deployed. Also updated the style a bit.

Owner

progrium commented Nov 12, 2013

Pulled and deployed. Also updated the style a bit.

@fgrehm

This comment has been minimized.

Show comment
Hide comment
@fgrehm

fgrehm Nov 12, 2013

Contributor

Awesome! And it werks :)

Contributor

fgrehm commented Nov 12, 2013

Awesome! And it werks :)

@fgrehm fgrehm referenced this pull request Dec 9, 2013

Merged

Minor tweaks #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment