Lots of goodies #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t on GitHub and will see a "blank" page :)
|
|
||
| bodyStr := string(body) | ||
| // Ajust relative links for specific git revisions | ||
| // FIXME: This doesn't handle relative links on the template / layout, |
There was a problem hiding this comment.
Oh, I got excited about sending the PR and forgot to mention this. I'm not sure what's the best approach for handling links relative to the current git branch on the generated HTML so I hacked together this regex to at least adjust links inside the markdown :P
There was a problem hiding this comment.
This is pretty good. We could expose the ref to the template, but since there's no logic it makes it difficult to handle the default master case vs non-master. This seems good enough for now.
|
Pulled and deployed. Also updated the style a bit. |
|
Awesome! And it werks :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we go, my first Golang PR EVAH 😃 🎆
What's on this PR:
repo~refACCESS_TOKENis not setgo fmt