Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the private key prefix to 128+pub #2

Closed
melvincarvalho opened this issue Nov 6, 2014 · 3 comments

Comments

@melvincarvalho
Copy link
Contributor

commented Nov 6, 2014

I think it would be a good idea to change the private key prefix from what it is now to 'b' + 128.

This will enable us to use lots of tooling without having to reengineer it and/or get patches upstream which can be quite time and work intensive.

I dont think much will break, because the underying private key is still the same independent of the base58 check prefix.

@MarkPfennig

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2014

fixed in 0cb2a1a

need to create a key converter for old address keys or modify /brain

@MarkPfennig MarkPfennig closed this Dec 4, 2014
@melvincarvalho

This comment has been minimized.

Copy link
Contributor Author

commented Dec 4, 2014

Why not add it to brain itself, there is an inbuilt converer on the upstream version

@MarkPfennig

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2014

Yes, that's the plan, code is in there, just needs a quick UI and function to show pre 0.9.3 key and post 0.9.3 key. Building now for release tomorrow.

dbkeys pushed a commit that referenced this issue Aug 9, 2018
dbkeys pushed a commit that referenced this issue Aug 27, 2018
dbkeys pushed a commit that referenced this issue Nov 7, 2018
Merge dev into master
dbkeys pushed a commit that referenced this issue Nov 7, 2018
Merge with bitmark-protocol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.