Skip to content

Conversation

@kryanbeane
Copy link
Contributor

Issue link

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from chipspeak and dimakis November 11, 2025 13:31
@kryanbeane kryanbeane force-pushed the dashboard-httproute-fix branch from 051202a to ec56720 Compare November 11, 2025 14:42
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.13%. Comparing base (1d96cb2) to head (4bbbcbb).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/codeflare_sdk/ray/cluster/cluster.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
- Coverage   94.28%   94.13%   -0.16%     
==========================================
  Files          24       24              
  Lines        2083     2096      +13     
==========================================
+ Hits         1964     1973       +9     
- Misses        119      123       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kryanbeane
Copy link
Contributor Author

/override kubernetes

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

@kryanbeane: Overrode contexts on behalf of kryanbeane: kubernetes

In response to this:

/override kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kryanbeane kryanbeane force-pushed the dashboard-httproute-fix branch from ec56720 to 4bbbcbb Compare November 11, 2025 16:24
@kryanbeane kryanbeane changed the title fix: use platform namespace for http route fix(RHOAIENG-38647): use platform namespace for http route Nov 11, 2025
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CathalOConnorRH, pawelpaszki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CathalOConnorRH,pawelpaszki]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kryanbeane kryanbeane merged commit f336a2d into project-codeflare:main Nov 11, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants