Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating rbacs and logging error #83

Merged
merged 5 commits into from
Jun 21, 2023

Conversation

Fiona-Waters
Copy link
Contributor

@Fiona-Waters Fiona-Waters commented Jun 13, 2023

Resolves #81

While working through the quick start guide instascale logs showed that the instascale-ocm-secret could not be found.
I updated the rbacs to include secrets. I also updated the error log to include the related error in the output.

Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are two independent changes -- they should be two separate commits. One for the logging change, one for the role change.

deployment/instascale-clusterrole.yaml Show resolved Hide resolved
deployment/instascale-clusterrole.yaml Show resolved Hide resolved
@codificat
Copy link

I am testing instascale on an OSD cluster and I am seeing RBAC issues too.

Besides the Secret access covered so far, my logs also complain about ClusterVersion:

W0616 10:28:53.704620 1 reflector.go:324] go/pkg/mod/k8s.io/client-go@v0.23.0/tools/cache/reflector.go:167: failed to list *v1.ClusterVersion: clusterversions.config.openshift.io is forbidden: User "system:serviceaccount:opendatahub:instascale-instascale-sa" cannot list resource "clusterversions" in API group "config.openshift.io" at the cluster scope
E0616 10:28:53.704644 1 reflector.go:138] go/pkg/mod/k8s.io/client-go@v0.23.0/tools/cache/reflector.go:167: Failed to watch *v1.ClusterVersion: failed to list *v1.ClusterVersion: clusterversions.config.openshift.io is forbidden: User "system:serviceaccount:opendatahub:instascale-instascale-sa" cannot list resource "clusterversions" in API group "config.openshift.io" at the cluster scope

which seems to come from

cv := &configv1.ClusterVersion{}
err := r.Client.Get(context.TODO(), types.NamespacedName{Name: "version"}, cv)
if err != nil {
return fmt.Errorf("can't get clusterversion: %v", err)
}

I believe this should also be added

anishasthana
anishasthana previously approved these changes Jun 21, 2023
@anishasthana anishasthana merged commit d39bcfe into project-codeflare:main Jun 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Update rbacs to include secrets
4 participants