Skip to content

Commit

Permalink
Don't bind a hotkey for Fire Guardian summoning
Browse files Browse the repository at this point in the history
The action of binding a hotkey persists during the same game session,
and in this particular case since we're reusing a hotkey that's already
bound to an engine command, some dumb behaviour ensues when switching to
a scenario where the menu item doesn't exist and the player needs to use
the engine command again.

This bug was 7 years old.
  • Loading branch information
irydacea committed Jul 27, 2020
1 parent 5472251 commit 29ec21d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
3 changes: 3 additions & 0 deletions changelog.md
Expand Up @@ -19,6 +19,9 @@ Version 0.10.5+dev:
affecting a lore glyph.
* E3S8C - Breakdown:
* Increase turn limit.
* Don't bind a hotkey for the Summon Fire Guardian menu item since it gives
the game engine an existential crisis when switching scenarios in the
same session.

* Units:
* Enable Troll Whelp → Troll Shaman unit progression for new runs.
Expand Down
8 changes: 0 additions & 8 deletions macros/unit-utils.cfg
Expand Up @@ -575,14 +575,6 @@
# po: wesnoth-units textdomain in mainline.
description= _ "Summon Fire Guardian"
image="icons/menu-fire.png"
[default_hotkey]
key=r
#ifdef APPLE
cmd=yes
#else
ctrl=yes
#endif
[/default_hotkey]
[show_if]
# Only during the player's turn
{VARIABLE_NUMERICAL_EQUALS side_number 1}
Expand Down

0 comments on commit 29ec21d

Please sign in to comment.