test_requests_responses to unittest #7

Merged
merged 13 commits into from May 27, 2012

Conversation

Projects
None yet
3 participants
@diogobaeder
Contributor

diogobaeder commented May 27, 2012

test_requests_responses completely migrated to unittest.

Suggestion for future enhancement: split those tests into four modules:
1- Stub classes and utilities
2- Public tests
3- TwoLegged tests
4- ThreeLegged tests
This would make those tests even cleaner, I believe. If you agree, please tell me and I can go on with these changes.

@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot May 27, 2012

This pull request fails (merged 3d397c1 into b1fb1e2).

This pull request fails (merged 3d397c1 into b1fb1e2).

@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot May 27, 2012

This pull request fails (merged 0a91d9f into b1fb1e2).

This pull request fails (merged 0a91d9f into b1fb1e2).

@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot May 27, 2012

This pull request passes (merged 142341b into b1fb1e2).

This pull request passes (merged 142341b into b1fb1e2).

@diogobaeder

This comment has been minimized.

Show comment Hide comment
@diogobaeder

diogobaeder May 27, 2012

Contributor

Sorry, forgot to run it against py2.6 again. Already fixed. (Maybe we should use unittest2 to have better assertions? Just a suggestion.)

Contributor

diogobaeder commented May 27, 2012

Sorry, forgot to run it against py2.6 again. Already fixed. (Maybe we should use unittest2 to have better assertions? Just a suggestion.)

muffinresearch added a commit that referenced this pull request May 27, 2012

Merge pull request #7 from diogobaeder/master
Test refactor + improvements

@muffinresearch muffinresearch merged commit 0a4a76d into project-fondue:master May 27, 2012

@muffinresearch

This comment has been minimized.

Show comment Hide comment
@muffinresearch

muffinresearch May 27, 2012

Contributor

Fantastic work Diogo, many thanks!

Contributor

muffinresearch commented May 27, 2012

Fantastic work Diogo, many thanks!

@diogobaeder

This comment has been minimized.

Show comment Hide comment
@diogobaeder

diogobaeder May 27, 2012

Contributor

Thanks, man, I'm having a lot of fun with this project, indeed. :-)

Contributor

diogobaeder commented May 27, 2012

Thanks, man, I'm having a lot of fun with this project, indeed. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment