Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JvDBGrid: Removed unnecessary condition #132

Conversation

@MHumm
Copy link
Contributor

@MHumm MHumm commented May 23, 2019

As requested in the acknowledged Mantis issue 6302
http://issuetracker.delphi-jedi.org/view.php?id=6302

@obones
Copy link
Member

@obones obones commented May 24, 2019

@ahausladen do you have an opinion on this? The issue reporter suggested to check with you, but it's been so long that I can't remember about this.

@MHumm
Copy link
Contributor Author

@MHumm MHumm commented Sep 14, 2019

@ahausladen "Ping": did you already find the time to look at this one?

@ahausladen
Copy link
Contributor

@ahausladen ahausladen commented Sep 15, 2019

I don't know what that bug report has to do with me. Sure, the code line was "modified" by me in 2006 but only because I changed the line indention with the commit f8d4e5e (try/finally block). So there is no actual relation between me and that line of code.

@MHumm
Copy link
Contributor Author

@MHumm MHumm commented Apr 2, 2021

What's the status of this? The suggestion of the reporter doesn't seem to be really usefull given @ahausladen's comment...

@ahausladen
Copy link
Contributor

@ahausladen ahausladen commented Apr 3, 2021

With the removal of the "(dgIndicator in Options)" the OnTitleArrowMenuEvent that is only available if the indicator is visible can now be triggered by right clicking on the first column. So in order to not trigger that event if no indicator is visible, the check has to be moved to the inner if statement. I will make the commit after merging this.

@ahausladen ahausladen merged commit 64d6355 into project-jedi:master Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants