Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed fix for "In a DBGrid when you move a column at the right end, the grid is repositioned to the start left" #91

Conversation

Projects
None yet
2 participants
@MHumm
Copy link
Contributor

commented Apr 25, 2019

mhumm
Implemented proposed fix for "In a DBGrid with dgRowSelect in Options…
…, TitleButton = True and TitleButtonAllowMove = True, whether the horizontal scrollbar is present and you move a column at the right end, the grid is repositioned to the start left."
@@ -2819,6 +2819,7 @@ procedure TJvDBGrid.MouseUp(Button: TMouseButton; Shift: TShiftState;
ACol: Longint;
DoClick: Boolean;
ALeftCol: Integer;
SI: TScrollInfo;

This comment has been minimized.

Copy link
@obones

obones Apr 30, 2019

Member

This variable should really be named OriginalScrollInfo

@@ -2872,7 +2873,18 @@ procedure TJvDBGrid.MouseUp(Button: TMouseButton; Shift: TShiftState;
ColWidths[FSizingIndex]);
end
else
inherited MouseUp(Button, Shift, X, Y);
begin
SI.cbSize := SizeOf(SI); //

This comment has been minimized.

Copy link
@obones

obones Apr 30, 2019

Member

What's the point of the empty comment?

inherited MouseUp(Button, Shift, X, Y);
begin
SI.cbSize := SizeOf(SI); //
SI.fMask := SIF_POS; // Store scrollbar position

This comment has been minimized.

Copy link
@obones

obones Apr 30, 2019

Member

This comment should really be on the next line

@MHumm

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

Superseded by #116

@MHumm MHumm closed this May 1, 2019

@MHumm MHumm deleted the MHumm:Mantis6540_ResetScrollbarWhenMovingCOlumns branch May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.