Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch path from hybrid to cost-management #1067

Merged
merged 1 commit into from Oct 22, 2019

Conversation

dlabrecq
Copy link
Contributor

@dlabrecq dlabrecq commented Oct 22, 2019

All references to hybrid should change to cost-management

https://github.com/project-koku/koku-ui/issues/1066

Doesn't address issues with left-side Insights nav

@codecov-io
Copy link

codecov-io commented Oct 22, 2019

Codecov Report

Merging #1067 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1067   +/-   ##
=======================================
  Coverage   75.66%   75.66%           
=======================================
  Files         228      228           
  Lines        4369     4369           
  Branches      813      813           
=======================================
  Hits         3306     3306           
  Misses        950      950           
  Partials      113      113

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b4c4f5...03f69d0. Read the comment docs.

@boaz0
Copy link
Contributor

boaz0 commented Oct 22, 2019

@ryelo - I can't navigate to settings. It redirects me to overview page.

Copy link
Contributor

@boaz0 boaz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except to the regression with settings.
Also, maybe you can delete the comments.

@dlabrecq dlabrecq merged commit 9449450 into project-koku:master Oct 22, 2019
@dlabrecq
Copy link
Contributor Author

The setting navigation has been fixed by Insights -- I've confirmed with CI beta

@dlabrecq dlabrecq deleted the 1066-hybrid-path branch November 13, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants