Update contributing guidelines #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddrysdale
approved these changes
Nov 22, 2019
|
|
||
| Once the changes are made locally, the author creates a new commit on their | ||
| newly created branch based on master, then pushes to their own fork, and creates | ||
| a PR from the GitHub UI. The author then selects one or more reviewers. |
There was a problem hiding this comment.
Might be a bit tricky for an external contributor to select a reviewer?
There was a problem hiding this comment.
Yeah, hopefully some of us will notice though.
CONTRIBUTING.md
Outdated
| a PR from the GitHub UI. The author then selects one or more reviewers. | ||
|
|
||
| The commit / PR description should follow | ||
| [standard git commit conventions](https://chris.beams.io/posts/git-commit/). |
CONTRIBUTING.md
Outdated
| [standard git commit conventions](https://chris.beams.io/posts/git-commit/). | ||
| button in the GitHub UI. The UI will suggest a final commit message composed of | ||
| the PR title, and individual commit messages as a bullet point list; the author | ||
| can then reword the final commit message in the UI, usually discarding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.