Playbook signature validation #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
force-pushed
the
signature
branch
from
0839560
to
0476eaf
Compare
ares
reviewed
Nov 20, 2020
receptor_satellite/run.py
Outdated
| @@ -64,10 +66,11 @@ async def run(self): | |||
|
|
|||
| await self.satellite_api.init_session() | |||
| try: | |||
| self.queue.ack(self.playbook_run_id) | |||
| self.playbook = playbook_verifier.verify(self.playbook) | |||
There was a problem hiding this comment.
I think we'll need to make this optional, however the setting should default to true.
There was a problem hiding this comment.
Do we? We rely on cloud to know if a client can or cannot process signed playbooks, I assumed this would be based solely on receptor-satellite version. If we make this optional, then cloud would have to know about version and value of the setting
There was a problem hiding this comment.
In case we want to disable it at the last minute, we can switch the commented and uncommented lines here https://github.com/project-receptor/receptor-satellite/blob/a96253b05daaddbc07de8cef1d50a1a6d391bbab/receptor_satellite/playbook_verifier_adapter.py
|
Thanks @adamruzicka, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: