Tombstone Room Screen and tombstone indicator

[alanpoon]

Screen.Recording.2025-07-09.at.9.52.16.AM.mov

• Add Tombstone badge in room preview, in replacement of unread messages count
• Add Successor room redirection if room is tombstones
• Test on Desktop
• Test on Mobile
• m.room.tombstone event, replacement_room: A room_id that user has joined -> Click join_successor button redirect to successor room.
• m.room.tombstone event, replacement_room: A room_id that user has not joined. -> Shows "You are not invited to this room" error. Currently shows "Client unable to find the room".
• Display m.room.tombstone's body message
  How to tombstone a room?
• Successor Room has been loaded when set_displayed_tombstone.
• Successor Room has not been loaded when set_displayed_tombstone.

1. Go to Element's Developer tool, send custom event (m.room.tombstone)
   `{ "body" : "The room has been replaced", "replacement_room": "[Some room_id]"}

[kevinaboos]

Is this ready for review? Seems like there are still a few remaining to-do items, or do you have specific questions? If so, let me know what you're having problems with.

[alanpoon]

Is this ready for review? Seems like there are still a few remaining to-do items, or do you have specific questions? If so, let me know what you're having problems with.

A room is tombstoned if it has received a m.room.tombstone state event; see Room::tombstone_content.

Currently, my solution decides if a room is tombstoned when adding the new room instead of actually waiting for room state event m.room.tombstone.

1. I am wondering if I should extend RoomScreen.rs instead of a new tombstone screen.
2. Should I have that many mutex lock when displaying the tombstone screen?

[kevinaboos]

1. I am wondering if I should extend RoomScreen.rs instead of a new tombstone screen.

Certainly yes, this should be part of RoomScreen. Note that users may still want to view and interact with events in a tombstoned room; they just won't be able to send messages to it.

2. Should I have that many mutex lock when displaying the tombstone screen?

Hm? Not sure what you're referring to.

[kevinaboos]

Thanks, this is a great start. I left some comments about the structure of the code and how tombstoned info is sent throughout the app.

In general, when we discover a new room from the homeserver, don't we already know whether it has been tombstoned? And when we know whether a room is_tombstoned, we should be able to immediately retrieve the tombstoned info via successor_room(), which internally calls tombstone_content()?

I think we should be able to store the tombstoned/successor room information in the RoomScreen itself (more specifically, the TimelineUiState) once we discover it. We can do this instead of just maintaining a single is_tombstoned bool, right?

[kevinaboos]

Things look generally good! Just a few small comments.

Apologies for the delay, I was working on a conference talk and traveling to said conference, as you likely already know.

[kevinaboos]

thanks, great work!

[kevinaboos]

I thought we had a "join room" icon already, but apparently not. I'll add one and use it for both the successor room button the join room modal as well.