Fix joining replacement room and ensure navigation works#584
Merged
kevinaboos merged 3 commits intoSep 25, 2025
Conversation
Previously, PR project-robius#536 added support for showing a tombstoned room and information about its successor/replacement room, but did not fully handle the case where a new room is unknown. We now handle that properly, and also support deferred navigation to the newly-joined room that waits for it to actually joined and fully loaded/received by our client from the homeserver, at which point it can actually jump to that new room.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, PR #536 added support for showing a tombstoned room and information about its successor/replacement room, but did not fully handle the case where a new room is unknown. We now handle that properly, and also support deferred navigation to the newly-joined room that waits for it to actually joined and fully loaded/received by our client from the homeserver, at which point it can actually jump to that new room.
This also ensures that all
AppStateActions are just bare actions, not widget actions. This is more efficient, as widget actions require forced cloning.