Ensure that message details are only set for a drawn item once#593
Merged
kevinaboos merged 1 commit intoOct 1, 2025
Merged
Conversation
Recently, a minor bug snuck in where it was possible for a message item's widget to have incomplete `MessageDetails`, because the related event ID was not always calculated but was still being re-set for the message item when it did not need to be re-set. Now we only set it once when the message *content* is first drawn, which is correct in all cases, and also more efficient!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, a minor bug snuck in where it was possible for a message item's widget to have incomplete
MessageDetails, because the related event ID was not always calculated but was still being re-set for the message item when it did not need to be re-set.Now we only set it once when the message content is first drawn, which is correct in all cases, and also more efficient!