Fully refactor non-Timeline components into the RoomInputBar#602
Merged
kevinaboos merged 5 commits intoOct 14, 2025
Merged
Conversation
The `RoomInputBar` widget now contains more of the widgets that were previously in the `RoomScreen`, for the sake of better modularity, separation of concerns, and more. By having the `RoomInputBar` contain and manage all these subwidgets, it can now properly show/hide various subwidgets at the right time. In the future, this will allows us to ensure that all the components fit vertically within the parent `RoomScreen` window, by using the new `Fit` size specifier with maximum relative size values. Currently, accessing widgets in the `RoomInputBar` from within the `RoomScreen`'s code is not fully working, probably just an issue with live ID resolution when accessing things like the `EditingPane`, `ReplyPreview`, `TombstoneFooter`, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RoomInputBarwidget now contains more of the widgets that were previously in theRoomScreen, for the sake of better modularity, separation of concerns, and more.By having the
RoomInputBarcontain and manage all these subwidgets, it can now properly show/hide various subwidgets at the right time. In the future, this will allows us to ensure that all the components fit vertically within the parentRoomScreenwindow, by using the newFitsize specifier with maximum relative size values.Currently, accessing widgets in the
RoomInputBarfrom within theRoomScreen's code is not fully working, probably just an issue with live ID resolution when accessing things like theEditingPane,ReplyPreview,TombstoneFooter, etc.Closes #519.
Closes #488.