Ensure that RoomInputBar components don't exceed 5/8 of the RoomScreen's height#608
Merged
kevinaboos merged 1 commit intoOct 18, 2025
Conversation
…creen's height This primarily applies to the TextInput within the RoomInputBar, but it also limits the height of everything else within the RoomInputBar, such as the ReplyPreview + TextInput together. Update makepad version to include Eddy's latest commit that supports Fit size bounds with maximum sizes that are relative to an ancestor widget.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This primarily applies to the TextInput within the RoomInputBar, but it also limits the height of everything else within the RoomInputBar, such as the ReplyPreview + TextInput together.
Makepad's TextInput widget still doesn't support internal scrolling, so you cannot see all the text when it exceeds the max size bound. But it's still a major improvement because it doesn't push the buttons off-screen.
Update makepad version to include Eddy's latest commit that supports Fit size bounds with maximum sizes that are relative to an ancestor widget.