Support (un)pinning events via the message context menu#610
Merged
Conversation
Properly determine whether a given message can be pinned or unpinned by the current user (for purposes of the message context menu). Upgrade to rust edition 2024 so we can use let-chains (FINALLY!)
Note: this PR still doesn't show pinned messages, that requires additional significant UI work.
kevinaboos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly determine whether a given message can be pinned or unpinned by the current user (for purposes of the message context menu).
Fully handle pin/unpin event commands in the message context menu.
Upgrade to rust edition 2024 so we can use let-chains (FINALLY!)
Note: this PR still doesn't show pinned messages; that requires additional significant UI work. However, it does include all of the infrastructure to actually subscribe to the stream of changes in the pinned events list for a given room, and we now subscribe upon opening a room and unsubscribe upon closing it.