Make SpacesBar and NavigationTabBar content/buttons behave properly alongside each other#627
Merged
Merged
Conversation
There's currently a problem where the SpacesBarWrapper is getting redrawn constantly, which is likely due to the nonstop flow of `NextFrame` events coming into it. But I don't know where those events are coming from, so I haven't yet been able to stop them.
Currently the hover action seems to take precedence over the state of it being "active"
kevinaboos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's currently a problem where the SpacesBarWrapper is getting redrawn constantly, which is likely due to the nonstop flow ofFixed, it was an issue caused by playing an animation inNextFrameevents coming into it. But I don't know where those events are coming from, so I haven't yet been able to stop them.SpacesBarEntry::set_metadata(), which gets called from a draw pass. Apparently that's a no-no.