Allow hiding a room from the rooms list#642
Merged
Merged
Conversation
This is useful when extreme homeserver latency causes a big delay between joining a successor room and the RoomListService receiving the update that the tombstoned room should no longer be considered "active" and can be removed. Or, if the room never gets removed, the user can still observe the expected result. In the future, this could also be used to allow the user themselves to permanently hide certain rooms, e.g., spam invites that they do not want to see without requiring them to fully clear the client cache. However, to support that, we'd need to distinguish between hiding a room temporarily vs permanently, and then save the list of permanently-hidden rooms to the persistent app state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful when extreme homeserver latency causes a big delay between joining a successor room and the RoomListService receiving the update that the tombstoned room should no longer be considered "active" and can be removed. Or, if the room never gets removed, the user can still observe the expected result.
In the future, this could also be used to allow the user themselves to permanently hide certain rooms, e.g., spam invites that they do not want to see without requiring them to fully clear the client cache. However, to support that, we'd need to distinguish between hiding a room temporarily vs permanently, and then save the list of permanently-hidden rooms to the persistent app state.