Avoid too long utsnames #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When stacker builds a container, it uses the s.TemporaryWritableSnapshot(name) results. This can be > 63 chars, which lxc will balk at. For instance: error: failed setting config lxc.uts.name to temp-snapshot-build-cluster-api-provider-sveltos-amd64-2544038502: setting config item for the container failed We don't actually need a good name for the container, it just needs to run. So just use "stacker". If we care, we could instead do something only if len(name) > 63... Signed-off-by: Serge Hallyn <serge@hallyn.com>
andaaron
approved these changes
May 20, 2022
|
@mikemccracken shall we merge this as fix for #292? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stacker builds a container, it uses the s.TemporaryWritableSnapshot(name)
results. This can be > 63 chars, which lxc will balk at. For instance:
error: failed setting config lxc.uts.name to temp-snapshot-build-cluster-api-provider-sveltos-amd64-2544038502: setting config item for the container failed
We don't actually need a good name for the container, it just needs to run.
So just use "stacker".
If we care, we could instead do something only if len(name) > 63...
Signed-off-by: Serge Hallyn serge@hallyn.com