feat(import): add "copy" support for import #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge this yet, only part 1/2 of the patchset |
rchincha
force-pushed
the
import-copy
branch
7 times, most recently
from
731bb36
to
6cf881d
Compare
rchincha
changed the title
rchincha
force-pushed
the
import-copy
branch
17 times, most recently
from
945f04a
to
0f418be
Compare
rchincha
changed the title
hallyn
reviewed
Dec 9, 2022
hallyn
reviewed
Dec 9, 2022
hallyn
reviewed
Dec 9, 2022
hallyn
reviewed
Dec 9, 2022
hallyn
reviewed
Dec 9, 2022
hallyn
reviewed
Dec 9, 2022
rchincha
force-pushed
the
import-copy
branch
5 times, most recently
from
d4489b1
to
729ccbc
Compare
rchincha
force-pushed
the
import-copy
branch
from
729ccbc
to
e6fb827
Compare
hallyn
reviewed
Dec 14, 2022
hallyn
reviewed
Dec 14, 2022
hallyn
reviewed
Dec 14, 2022
Currently, "import:" directive only allows for temporarily mounting previously layers, and actual copying would have to be done via "run:" directive. But in cases where there is no shell in the current layer, there was no way to achieve this, greatly limiting usability for packaging golang binaries. Adding support using "dest:" option under "import:" directive. Thanks @smoser for the review and fix. Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
rchincha
force-pushed
the
import-copy
branch
from
e6fb827
to
39a5226
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, "import:" directive only allows for temporarily mounting previously layers, and actual copying would have to be done via "run:" directive. But in cases where there is no shell in the current layer, there was no way to achieve this, greatly limiting usability for packaging golang binaries.
Adding support using "dest:" option under "import:" directive.
Signed-off-by: Ramkumar Chinchani rchincha@cisco.com
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.