Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#494 - Clock Widget #560

Merged
merged 28 commits into from Feb 16, 2019
Merged

Conversation

@jtj9817
Copy link
Contributor

jtj9817 commented Dec 9, 2018

Description

This WIP milestone now includes the widget configuration screen, fulfilling the 2nd feature request opened in this issue #494.

File Changes Summary

Android/app/src/main/AndroidManifest.xml

Added the necessary configuration for the widget to work properly

Android/app/src/main/java/widget/ClockWidget.java

Activity file for the widget which it uses when it's created

Android/app/src/main/java/widget/ClockWidgetConfigureActivity.java

Configuration activity when the widget is first created

Android/app/src/main/res/drawable/clockwidget_preview.png

A preview image used for the Clock Widget to show the user what the widget will look like

Android/app/src/main/res/layout/clock_widget.xml

Layout file for the clock widget

Android/app/src/main/res/layout/clock_widget_configure.xml

Layout file for the configuration activity for the clock widget

Android/app/src/main/res/values/strings.xml

Updated the strings to be used for the clock widget config activity

Android/app/src/main/res/xml/clock_widget_info.xml

Defines the settings for the clock widget when it's instantiated

Other files

All the changes to other files are very minor changes. The changes on XML files that includes 'dimens.xml' in its name are related to the widget's layout size on the launcher/home screen. Changes to colors.xml is just a newline.

Demonstration

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • ./gradlew assembleDebug assembleRelease
  • ./gradlew checkstyle

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
jtj9817 added 28 commits Oct 30, 2018
Starting point for #534

Added the 'Offline Maps' section to the Navigation Drawer complete with the icon. 'fragment_offlinemaps.xml' and 'OfflineMapsFragment.java' also created.
Implemented the changes as requested by the discussion in #545.
Added displaying timezone and date. Reverted some commits that will be unnecessary for this feature in the meantime.
Added configuration screen for World Clock Widget to be shown on launcher/home screen. Also fixed the display for the time in the widget while displaying the timezone name properly.
@jtj9817 jtj9817 closed this Dec 9, 2018
@jtj9817 jtj9817 reopened this Dec 9, 2018
@jtj9817 jtj9817 closed this Dec 9, 2018
@jtj9817 jtj9817 reopened this Dec 9, 2018
@Swati4star

This comment has been minimized.

Copy link
Member

Swati4star commented Dec 15, 2018

@jtj9817 Is it a WIP or a complete working one?

@jtj9817

This comment has been minimized.

Copy link
Contributor Author

jtj9817 commented Dec 16, 2018

It's a complete working one although only with Digital Clock interface. You can test it for yourself and see if it's satisfactory enough to be implemented in the official release of Travel Mate.

@Swati4star

This comment has been minimized.

Copy link
Member

Swati4star commented Dec 17, 2018

@jtj9817 We already have a world clock option in the naivigation drawer -> utilities.
Do we need a new screen that you have created? or can we just use the settings from the above screen only?

@jtj9817

This comment has been minimized.

Copy link
Contributor Author

jtj9817 commented Dec 17, 2018

@Swati4star The configuration screen for the widget is a separate process instantiated by creating a widget, therefore the configuration screen that I created will be needed. I'm aware of the World Clock option in the Utilities section of the app but replicating that in the configuration screen is difficult and my implementation is sufficient enough.

@jtj9817

This comment has been minimized.

Copy link
Contributor Author

jtj9817 commented Jan 6, 2019

@Swati4star any updates for this PR? Any steps I should take to open a new PR?

@Swati4star Swati4star changed the title Clock Widget WIP #3 #494 - Clock Widget Feb 16, 2019
@Swati4star Swati4star merged commit 6b1c5e3 into project-travel-mate:master Feb 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Swati4star

This comment has been minimized.

Copy link
Member

Swati4star commented Feb 16, 2019

Merged! Thanks @jtj9817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.