Skip to content
This repository has been archived by the owner. It is now read-only.

Manifest CLI Option Does Not Override Default TrueOS Manifest In Makefile #6

Closed
maxsteciuk opened this issue Oct 10, 2018 · 1 comment
Closed

Manifest CLI Option Does Not Override Default TrueOS Manifest In Makefile #6

maxsteciuk opened this issue Oct 10, 2018 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@beanpole135 @maxsteciuk
@maxsteciuk
Copy link
Contributor

@maxsteciuk maxsteciuk commented Oct 10, 2018

Providing the trident-master.json manifest via the command-line option does not override the default TrueOS manifest set in /usr/src_tmp/release/Makefile. This leads to building TrueOS base ISO instead of Trident ISO.

The issue seems to be due to $TRUEOS_MANIFEST variable not exported from the script to Makefile before invoking it.
maxsteciuk added a commit to maxsteciuk/trident-build that referenced this issue Oct 10, 2018
@maxsteciuk
[trident-build] Issue project-trident#6: Fixed the issue of CLI manif…
7ee5358 
…est option not being propagated to underlying Makefile
beanpole135 added a commit that referenced this issue Oct 10, 2018
@beanpole135
Merge pull request #7 from maxsteciuk/master
de7af71 
[trident-build] Issue #6: Fixed the issue of CLI manifest option not overriding manifest for ISO
@beanpole135
Copy link
Member

@beanpole135 beanpole135 commented Oct 10, 2018

Closed by PR #7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.