Skip to content
This repository has been archived by the owner. It is now read-only.

[trident-build] Issue #6: Fixed the issue of CLI manifest option not overriding manifest for ISO #7

Merged
merged 1 commit into from Oct 10, 2018
Merged

[trident-build] Issue #6: Fixed the issue of CLI manifest option not overriding manifest for ISO #7

merged 1 commit into from Oct 10, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@maxsteciuk @beanpole135
@maxsteciuk
Copy link
Contributor

@maxsteciuk maxsteciuk commented Oct 10, 2018

Before the fix:

+++++ manifest [/export/data/max/trident-build/trident-master.json]
Replacing PWD paths in TrueOS Manifest...
[INFO] Building ISO...
rm: *.iso: No such file or directory
make -C /usr/src_tmp/release obj
make -C /usr/src_tmp/release ftp cdrom
`ftp' is up to date.
env SRCDIR=/usr/src_tmp/release/.. OBJDIR=/usr/obj/usr/src_tmp/amd64.amd64/release >TRUEOS_MANIFEST=/usr/src_tmp/release/../release/trueos-manifest.json

After the fix:

+++++ manifest [/export/data/max/trident-build/trident-master.json]
[INFO] Building ISO...
rm: *.iso: No such file or directory
make -C /usr/src_tmp/release obj
make -C /usr/src_tmp/release ftp cdrom
`ftp' is up to date.
env SRCDIR=/usr/src_tmp/release/.. OBJDIR=/usr/obj/usr/src_tmp/amd64.amd64/release TRUEOS_MANIFEST=/export/data/max/trident-build/trident-master.json
@maxsteciuk
[trident-build] Issue project-trident#6: Fixed the issue of CLI manif…
7ee5358 
…est option not being propagated to underlying Makefile
@beanpole135 beanpole135 merged commit de7af71 into project-trident:master Oct 10, 2018
@beanpole135
Copy link
Member

@beanpole135 beanpole135 commented Oct 10, 2018

Looks good to me!
Thanks for sending that in!

@beanpole135 beanpole135 mentioned this pull request Oct 10, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.