Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uname -r since the kernel default has changed to 5.7 from 5.4 #103

Closed
karlgrose opened this issue Jul 1, 2020 · 2 comments
Closed

Use uname -r since the kernel default has changed to 5.7 from 5.4 #103

karlgrose opened this issue Jul 1, 2020 · 2 comments

Comments

Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@karlgrose
Copy link

@karlgrose karlgrose commented Jul 1, 2020

linuxver=`xbps-query -p pkgver linux | cut -d - -f 2 | cut -d . -f 1-2 | cut -d _ -f 1`

This seems to work better to reflect the currently booted kernel:

linuxver=$(uname -r | cut -d . -f 1-2 | cut -d _ -f 1)

now that the default PT kernel is no longer 5.4 (which, however, is still the package version for the current Void "linux" meta package).

@beanpole135
Copy link
Member

@beanpole135 beanpole135 commented Jul 1, 2020

Good catch. The current version routine requires that the "linux" meta-package be installed in order to grab the version, which might no longer be the case now that trident-base is no longer using the "linux" meta-package.

I don't think that using uname is the right approach though either: Since that routine runs after all the updates are performed, you could get into a situation where you are running an older kernel (5.4 for example), but the upgrade just removed the linux5.4 package and installed the linux5.7 package. Since we need to "xbps-reconfigure" an installed package, we need to scan the installed packages and pick one of the linux* packages that may have just been installed.

@beanpole135
Copy link
Member

@beanpole135 beanpole135 commented Jul 1, 2020

Ok, this should be fixed now: 587fa71

@beanpole135 beanpole135 closed this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment